make sure > can be used in segments when using bulk requests #9497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
| if (!empty($params['segment']) && strpos($url, 'segment=') > -1) { | ||
| // only unsanitize input when segment is actually present in URL, not when it was used from | ||
| // $defaultRequest in Request::getRequestArrayFromString from $_GET/$_POST | ||
| $params['segment'] = urlencode(Common::unsanitizeInputValue($params['segment'])); |
There was a problem hiding this comment.
The urlencode is not really needed I believe but added it for now. Otherwise we pass eg actions>5 (instead of actions%3E5) to the API methods. This shouldn't be a problem as all output should be proper encoded anyway. I did it because a comment here https://github.com/piwik/piwik/blob/2.15.1-b10/core/API/Request.php#L484 says we want URL encoded segments. I know Piwik\Segment can handle both urlencoded and urldecoded so it might be good to remove the urlencode here as it might be a problem if the segment parameter in the bulk request URL was encoded twice already.
mattab
pushed a commit
that referenced
this pull request
Jan 20, 2016
make sure > can be used in segments when using bulk requests
|
Quite a tricky bug fix, well done @tsteur |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9393
In #9393 (comment) I thought about fixing it in
API/Requestand even initially implemented it this way but after a lot of thinking it should be rather fixed ingetBulkRequestas the problem is actually specific to bulk requests. There is already this unsanitize https://github.com/piwik/piwik/blob/2.16.0-b1/plugins/API/API.php#L483 which is undone byRequest. So we should also fix it ingetBulkRequestagain where the initialunsanitizewas done.