VisitorMap doesnt show anything when segment parameter is URL-encoded #9495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
mattab
pushed a commit
that referenced
this pull request
Jan 12, 2016
VisitorMap doesnt show anything when segment parameter is URL-encoded
|
Good find! |
|
That change causes some UI tests to fail: The visitor maps are broken. On my local machine I got a js error.
I'll try to investigate... |
|
Guess I found the problem. If no segment is set, the segment for country map config is set to Before this change |
tsteur
added a commit
that referenced
this pull request
Jan 12, 2016
|
Thx for that, you're right. Fixed it in e62c61c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8813
took me a long time to reproduce. Used segment
&segment=pageTitle%3D%3DAbout%2520ExampleCode%3BcountryCode%3D%3Dde