Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostics RecommendedExtensionsCheck on HHVM 3.11 #9493

Closed
voidswitch opened this issue Jan 11, 2016 · 0 comments
Closed

Diagnostics RecommendedExtensionsCheck on HHVM 3.11 #9493

voidswitch opened this issue Jan 11, 2016 · 0 comments
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
2.16.0

Comments

@voidswitch
Copy link

I'm using Piwik on HHVM, and it's working great. Currently (Piwik 2.15.0 / HHVM 3.11) the extensions check does not recognize the simplexml extension. As it seems, it got renamed from SimpleXML to simplexml (note the case) sometime between HHVM updates.

I checked if simplexml was loaded, and changed /srv/nginx/piwik/plugins/Diagnostics/Diagnostic/RecommendedExtensionsCheck.php to check for simplexml instead of SimpleXML. The warning on the diagnostics page went away. I did not further test compatibility or other implications so far.
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. labels Jan 11, 2016
tsteur added a commit that referenced this issue Jan 11, 2016
@tsteur
refs #9493 check for extensions lowercase
6d48d64
@tsteur tsteur added this to the 2.16.0 milestone Jan 11, 2016
@tsteur tsteur self-assigned this Jan 11, 2016
@tsteur tsteur mentioned this issue Jan 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
2.16.0
Development

No branches or pull requests
2 participants
@tsteur @voidswitch