Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zend Hostname validator is outdated for current TLD names. #9485

Closed
sebastianpiskorski opened this issue Jan 8, 2016 · 0 comments
Closed

Zend Hostname validator is outdated for current TLD names. #9485

sebastianpiskorski opened this issue Jan 8, 2016 · 0 comments
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
2.16.0

Comments

@sebastianpiskorski
Copy link
Contributor

Currently Piwik is using Hostname validator from 2011, which won't pass modern TLDs. Zend hostname validator requires TLD to have no more than 10 characters. Both versions 2.15 and 3.0 are affected.:
https://github.com/piwik/piwik/blob/3.0/libs/Zend/Validate/Hostname.php#L560
https://github.com/piwik/piwik/blob/2.15.0/libs/Zend/Validate/Hostname.php#L560

Currently IANA allow such TLDs as:

  • TRAVELERSINSURANCE
  • BARCLAYCARD

which have respectively 18 and 11 characters and are valid TLD names.
source: http://data.iana.org/TLD/tlds-alpha-by-domain.txt

Newest version of hostname validator isn't a solution either, because its hardcoded domain list doesn't contain all possible domain names.
https://github.com/zendframework/zend-validator/blob/master/src/Hostname.php#L76
@sebastianpiskorski sebastianpiskorski mentioned this issue Jan 8, 2016
Merged
tsteur added a commit that referenced this issue Jan 12, 2016
@tsteur
Merge pull request #9486 from sebastianpiskorski/patch-2
784b7bb 
#9485 Allow up to 63 characters TLD in email
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jan 12, 2016
@tsteur tsteur added this to the 2.16.0 milestone Jan 12, 2016
@tsteur tsteur self-assigned this Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.16.0
Development

No branches or pull requests
2 participants
@tsteur @sebastianpiskorski