Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes calculation of fillup columns for subtables #9472

Merged
merged 2 commits into from Jan 10, 2016
Merged

Fixes calculation of fillup columns for subtables #9472

merged 2 commits into from Jan 10, 2016

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 4, 2016

When subtables are loaded for action tables, the subtable response is checked for missing columns.
This check didn't respect colspans, so it failed for those.

fixes #7219

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 4, 2016
@sgiehl sgiehl force-pushed the 7219 branch 3 times, most recently from 16a6f1f to 25b43c1 Compare January 5, 2016 18:26
tsteur added a commit that referenced this pull request Jan 10, 2016
@tsteur
Merge pull request #9472 from piwik/7219
f17a3c1 
Fixes calculation of fillup columns for subtables
@tsteur tsteur merged commit f17a3c1 into master Jan 10, 2016
@tsteur tsteur added this to the 2.16.0 milestone Jan 10, 2016
@tsteur tsteur deleted the 7219 branch January 10, 2016 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @tsteur