Add link to segmented visitor log in goal conversions overview #9465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
| @@ -37,6 +37,10 @@ | |||
| </li> | |||
| {% endif %} | |||
| </ul> | |||
|
|
|||
| <a href="javascript:;" class="segmentedlog" onclick="DataTable_RowActions_Registry.getActionByName('SegmentVisitorLog').createInstance({}).showVisitorLog('Goals.getMetrics', 'visitConvertedGoalId=={{ idGoal }}', {})"> | |||
There was a problem hiding this comment.
Could we maybe instead provide a static function SegmentedVisitorLog.show(method, segment) or similar? This way we could reuse it somewhere else more easily and would hide the dependency to RowActions etc.
Even better would be maybe if DataTable_RowActions_SegmentVisitorLog.prototype.doOpenPopover used this method as well so we do not use RowActions at all when calling SegmentedVisitorLog.show
|
I've refactored the code. @tsteur would you please have a look again. |
tsteur
added a commit
that referenced
this pull request
Jan 12, 2016
Add link to segmented visitor log in goal conversions overview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7411