Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command to run Plugin QA test locally #9450

Closed
wants to merge 4 commits into from
Closed

Command to run Plugin QA test locally #9450

wants to merge 4 commits into from

Conversation

diosmosis
Copy link
Member

Includes a command that makes it simple to run the plugin QA test in matomo-org/travis-scripts#18 locally. See the referenced PR or the command for details.

Requires merging matomo-org/travis-scripts#18 first.

@diosmosis diosmosis added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. labels Dec 27, 2015
@diosmosis diosmosis added this to the 2.16.0 milestone Dec 27, 2015
@tsteur
Copy link
Member

tsteur commented Jan 10, 2016

I know it's not finished yet but I'm wondering why the PHP test file is in travis repo https://github.com/piwik/travis-scripts/pull/18/files whereas the command is in core? Maybe it would be good to have it both in one place.

Also it would be good if we could hide this command and only show the command when a certain config option is set eg [Development]prodev=1 as it was eg needed / useful here as well: #8695 (comment)

Alternative (and maybe even better solution from core perspective) would be maybe to not have it in core and instead in some custom Pro plugin or so.

@mattab
Copy link
Member

mattab commented Jan 12, 2016

@diosmosis @tsteur Would there be maybe a way to decouple this QA test from the core, so that we could later iterate on the QA test suite independantly of core release?

@mattab mattab modified the milestones: 2.16.1, 2.16.0 Jan 20, 2016
@mattab mattab modified the milestones: 3.0.0, 2.16.x (LTS) Jul 18, 2016
@tsteur
Copy link
Member

tsteur commented Aug 30, 2016

@mattab what is supposed to happen with this change?

@mattab
Copy link
Member

mattab commented Aug 30, 2016

this is not needed now that we have a smaller set of plugins to maintain

@mattab mattab closed this Aug 30, 2016
@mattab mattab deleted the plugin_qa branch June 21, 2017 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @tsteur @mattab