Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In generate:test command, add relevant travis jobs if missing in .travis.yml file #9448

Closed
wants to merge 1 commit into from

Conversation

diosmosis
Copy link
Member

Adds relevant travis job(s) when .travis.yml file is present, the test target env var can be deduced and the job is missing from the matrix.

Notes:

  • Uses regexes to preserve original formatting.
  • Additions appear to be well formed as long as initial .travis.yml is well formed.

Fixes #9274

… travis job(s) when .travis.yml file is present, the test target env var can be deduced and the job is missing from the matrix.

Notes:
- Uses regexes to preserve original formatting.
- Additions appear to be well formed as long as initial .travis.yml is well formed.
@diosmosis diosmosis added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Dec 26, 2015
@diosmosis diosmosis added this to the 2.16.0 milestone Dec 26, 2015
@diosmosis diosmosis added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Dec 26, 2015
{
$travisYmlFile = PIWIK_INCLUDE_PATH . '/plugins/' . $pluginName . '/.travis.yml';
if (!file_exists($travisYmlFile)) {
$output->writeln("Plugin '$pluginName' has no .travis.yml file, skipping travis job addition.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create travis-yml in this case or at least show the command to generate it? Also we could explain that one might has to set artifacts-pass etc.

@mattab mattab modified the milestones: 2.16.1, 2.16.0 Jan 20, 2016
@mattab mattab modified the milestones: 3.0.0, 2.16.x (LTS) Apr 1, 2016
@tsteur
Copy link
Member

tsteur commented Aug 30, 2016

I'll close this issue for now. I think it's best to simply add all jobs from the beginning that may be needed at some point. Waiting times etc are not as big of an issue anymore currently anyway

@tsteur tsteur closed this Aug 30, 2016
@tsteur tsteur deleted the 9274_enable_ui_build_on_generate branch August 30, 2016 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants