Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package mnapoli/phpdocreader is abandoned, you should avoid using it. Use php-di/phpdoc-reader instead. #9445

Closed
tassoman opened this issue Dec 24, 2015 · 4 comments
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@tassoman
Copy link
Contributor

I've tried installing a new Piwik cloning the master branch and I got this warning message :)

@sgiehl
Copy link
Member

sgiehl commented Dec 24, 2015

We would need to update php-di/php-di as the version we use requires mnapoli/phpdocreader instead of php-di/phpdoc-reader

@sgiehl
Copy link
Member

sgiehl commented Dec 25, 2015

We won't be able to fix that before 3.0. As all newer versions of php-di/php-di require PHP 5.4

@sgiehl sgiehl added this to the 3.0.0-b1 milestone Dec 25, 2015
@sgiehl sgiehl added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Dec 25, 2015
@sgiehl
Copy link
Member

sgiehl commented Dec 25, 2015

Note: I'll close this ticket as it is almost fixed on 3.0 branch. composer.json was already adjusted, but the composer.lock needs an update, which will for sure be done before the release.

@sgiehl sgiehl closed this as completed Dec 25, 2015
@tassoman
Copy link
Contributor Author

Sure no problem! Have good times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

2 participants