New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude unneeded files/folders from git packages #9434
Conversation
Should we maybe add some more from here: https://github.com/piwik/piwik-package/blob/master/scripts/build-package.sh#L111 ? Some people seem to download ZIP from Github and this way it would contain similar content to the actual build.zip. Or maybe we would not even need it in the build-package anymore? That would be ideal |
Sure, we could include some more files for exclusion, but I'm unsure which files.... |
|
||
|
||
# Files excluded from git packages | ||
tests/ export-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reasons we also allow to have tests in Test
directory which we should remove as well if these paths apply to nested directories as well? or do they only apply to directories in root directory? Maybe we need to define /tests
or something similar to .gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it automatically remove .git folder?
Added a comment re absolute paths but otherwise seems ok to merge. FYI: This also affects zip downloads on github. I presume we want to remove it from there as well so it's 👍 but mentioning it just in case we want to let users download everything from there @mattab We certainly should create a follow up issue re https://github.com/piwik/piwik-package/blob/master/scripts/build-package.sh#L111 so we have a unified logic there and the definitions only in one place. |
FYI: The branch points to 3.0 but should be now 3.x-dev |
Hi @sgiehl - could you resolve the merge conflict? Then Looks good to merge |
4812888
to
6ccfbcc
Compare
rebased it on latest |
replaces #9406