Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds links to directly create goals when website has had no visitors yet #9424

Merged
merged 2 commits into from Dec 22, 2015
Merged

Adds links to directly create goals when website has had no visitors yet #9424

merged 2 commits into from Dec 22, 2015

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 21, 2015

fixes #9412

If adjusted the message and added links to create goals and custom variables:

image

@sgiehl sgiehl added Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 21, 2015
@sgiehl sgiehl added this to the 2.15.1 milestone Dec 21, 2015
@tsteur
Copy link
Member

tsteur commented Dec 21, 2015

FYI: I'm not sure if the Custom Variables link is needed since there is not really anything to manage. One can't create or manage them. This is a bit of a problem of the menu structure (see #9354 ) and we might move them actually to Diagnostics.

@sgiehl
Copy link
Member Author

sgiehl commented Dec 21, 2015

Ah ok. I'll remove that link

@sgiehl sgiehl changed the title Adds links to directly create goals or custom variables when website has had no visitors yet Adds links to directly create goals when website has had no visitors yet Dec 21, 2015
mattab
mattab reviewed Dec 22, 2015
View reviewed changes
plugins/SitesManager/lang/en.json
@@ -67,7 +67,8 @@
"SiteSearchUse": "You can use Piwik to track and report what visitors are searching in your website's internal search engine.",
"SiteWithoutDataTitle": "No data has been recorded yet",
"SiteWithoutDataDescription": "No analytics data has been tracked for this website yet.",
"SiteWithoutDataSetupTracking": "Please set up the %1$sJavaScript tracking code%2$s on your website and refresh the page.",
"SiteWithoutDataSetupTracking": "Please set up the %1$sJavaScript tracking code%2$s on your website if you haven't done that already.",
"SiteWithoutDataSetupGoals": "This message will disappear as soon as some data was tracked for this website. Meanwhile you may already start with setting up %1$ssome goals%2$s.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message will disappear as soon as some data was tracked for this website.

is it actually the case? i think user has to refresh the page currently. However it would be great if the page refreshed automatically as soon as some data is tracked..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also split the sentence into 2 strings so we can edit second one without changing the first :)

Meanwhile you may already start with setting up %1$ssome goals%2$s. -> In the meantime, maybe you would like to %1$sset up some Goals%2$s? or so?

@sgiehl
Copy link
Member Author

sgiehl commented Dec 22, 2015

I've splitted/changed the text and implemented a check for new visits using the live widget logic.

mattab pushed a commit that referenced this pull request Dec 22, 2015
Merge pull request #9424 from piwik/9412
f1b693e 
Adds links to directly create goals when website has had no visitors yet
@mattab mattab merged commit f1b693e into master Dec 22, 2015
@mattab mattab mentioned this pull request Dec 22, 2015
Closed
@mattab
Copy link
Member

mattab commented Dec 22, 2015

👍

@mattab mattab deleted the 9412 branch December 22, 2015 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @tsteur @mattab