Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: adding badges #9413

Merged
merged 2 commits into from Dec 20, 2015
Merged

README: adding badges #9413

merged 2 commits into from Dec 20, 2015

Conversation

spekulatius
Copy link
Contributor

No description provided.

@tsteur
Copy link
Member

tsteur commented Dec 20, 2015

Thanks for your PR. We have some badges at the end of the readme and some are duplicated now I think. Can you maybe move them to the end of the page?

@spekulatius
Copy link
Contributor Author

Hello @tsteur

thanks for your reply. I sorted this a bit more. Have a look and let me know what you think.

Spek

@tsteur
Copy link
Member

tsteur commented Dec 20, 2015

I think they were supposed to be at the bottom but I'd personally prefer them at the top as well. As mainly developers look at this it is quite useful and I think it's very common to have the badges at the top.

Leaving this to @mattab

mattab pushed a commit that referenced this pull request Dec 20, 2015
@mattab mattab merged commit d71ba20 into matomo-org:master Dec 20, 2015
@mattab
Copy link
Member

mattab commented Dec 20, 2015

since all projects put buttons at the top, and users expect it, it's useful to be consistent 👍 Thanks for the PR!

@spekulatius spekulatius deleted the patch-1 branch December 20, 2015 22:20
@mattab mattab changed the title adding badges README: adding badges Jan 29, 2016
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants