Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outline topBars #941

Closed
pebosi opened this issue Aug 17, 2009 · 6 comments
Closed

Outline topBars #941

pebosi opened this issue Aug 17, 2009 · 6 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
0.4.4

Comments

@pebosi
Copy link
Contributor

pebosi commented Aug 17, 2009

This patch outlines the two topBars with a small border and a background-image.
@pebosi
Copy link
Contributor Author

pebosi commented Aug 17, 2009

Attachment:
topbars-screenshot.png

@pebosi
Copy link
Contributor Author

pebosi commented Aug 17, 2009

Attachment:
piwik-941.patch

@mattab
Copy link
Member

mattab commented Aug 17, 2009

I am not sure about this UI modification. It seems to outline the top bar, which is a rarely used UI element and might distract users from focusing on the reports. What do others think?

@robocoder
Copy link
Contributor

I'm ok with adding the topbar div as a container. The css changes could be deferred to future themeability...

@mattab
Copy link
Member

mattab commented Aug 18, 2009

pebosi, if you are interested, you can have a look at what it would take to add theming in Piwik. I'll forward you an email.

It would be nice to leave the design of Piwik the same for the next few releases and try to add the theming feature in Core. Then themes could freely modify the look of the app.

@robocoder
Copy link
Contributor

In [1410], add #topBars div; css changes deferred

@pebosi pebosi added this to the Piwik 0.4.4 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
0.4.4
Development

No branches or pull requests
3 participants
@pebosi @mattab @robocoder