Exclude unneeded files/folders from git packages #9406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
RFC
|
👍 for this Should we maybe add some more from here: https://github.com/piwik/piwik-package/blob/master/scripts/build-package.sh#L111 would solve quite a few problems when people download the release from Gtihub etc |
|
This change sounds good, but targetting to 3.0.0-b1 just in case this could break something (let's play safe) |
|
Should I reopen the PR for 3.0 branch? |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requiring Piwik using composer there are all files included. Even those not required for running Piwik (like tests, .git files,...)
In order to exclude those files I've added some of them to .gitattributes as export-ignore.
Those files won't be included when git is used to build a package (e.g. download a repo as archive).
Those archives will also be used by composer when a specific version is requested.
Note: If a composer project requires a specific branch or dev-master, composer uses git to fetch all files instead of using an archive, so those files will still be included in that case.