Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events reports: option to view all columns: min, max and avg values #9399

Merged
merged 2 commits into from Dec 22, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 15, 2015

fixes #6761

Please notice in #6761 (comment) I asked whether we should also show metric "Events with values", "Visits" and "Unique visits (if present)".

In #9398 I issued another PR that can be merged optionally. This will make sure we remember if someone selected "tableAllColumns" the next time one clicks on the report again. It also makes sure to remember other settings.

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 15, 2015
@tsteur tsteur added this to the 2.15.1 milestone Dec 15, 2015
@mattab
Copy link
Member

mattab commented Dec 21, 2015

see feedback in #6761 (comment)

@tsteur
Copy link
Member Author

tsteur commented Dec 21, 2015

Added columns. I didn't change the naming of the columns so not sure if "Visits" and "Unique visitors" makes sense in this case

mattab pushed a commit that referenced this pull request Dec 22, 2015
Events reports: option to view all columns: min, max and avg values
@mattab mattab merged commit e045e82 into master Dec 22, 2015
@mattab mattab deleted the 6761 branch December 22, 2015 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants