Add possibility to specify a limit for visits in Live.getVisitorProfile #9390
Conversation
tsteur
added
not-in-changelog
|
@tsteur This fixture looks like it's got several visits by the same visitor: TwoSitesManyVisitsOverSeveralDaysWithSearchEngineReferrers Otherwise looks good to me! |
mattab
changed the title
|
That one is meant for referrers. I'll create a new fixture instead... |
|
Also it was generating many different visitors which was the problem with other fixtures as well |
|
Added a test. Tried to squash but it has a bit of a problem when doing so because of the renaming of |
|
fyi @tsteur tests fail with |
|
Can you try again? I think it had some problems re renaming the file from |
Add possibility to specify a limit for visits in Live.getVisitorProfile
fixes #9046
I tried to write some tests for it but failed. Problem: I couldn't really find a fixture where we have many different visits of the same visitor. Tried to write one for a visitor having only a few visits but couldn't figure out the
visitorId. I could probably get it by logging it in tracking when tests execute them but not trivial when there are also tracking requests for other users etc. It would be doable though. Does anyone maybe know a fixture defining many visits for one visitor? Then I'd add a test for it.Also: I have not named it
filter_limitorfilter_offsetsince this would be not really correct. As mentioned here #9046 (comment) these parameters are reserved for the root element. However,lastVisitsis not a root element. Applyingfilter_limit/filter_offsetforlastVisitsproperty would be confusing since someone else might expect it to apply forcountriesor another property. Therefore I added a new parameterlimitVisits. Let me know if there are any other thoughts on this.