Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor saveLanguage from Installation and CoreUpdater controllers #939

Closed
robocoder opened this issue Aug 16, 2009 · 2 comments
Closed
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@robocoder
Copy link
Contributor

In #759 and #937, the language selector posts to module=LanguagesManager, which appears odd if/when it appears in the address bar.

The selector's form action should depend on the context or be configurable.

@mattab
Copy link
Member

mattab commented Aug 17, 2009

Just to confirm, all the logic to deal with saving preferred language in session, etc. shoudl be done inside the API (and other modules should be able to statically call this API method in php)

@robocoder
Copy link
Contributor Author

In [1408], fixes #939 - refactor saveLanguage() from Installation and CoreUpdater controllers

Added Piwik_LanguagesManager_API::getLanguageForSession() and setLanguageForSession()

@robocoder robocoder added this to the Piwik 0.4.4 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants