Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different wordings for username/login in UsersManager #9372

Closed
tsteur opened this issue Dec 10, 2015 · 2 comments
Closed

Different wordings for username/login in UsersManager #9372

tsteur opened this issue Dec 10, 2015 · 2 comments
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
2.16.0

Comments

@tsteur
Copy link
Member

tsteur commented Dec 10, 2015

The wordings for both are probably different all over in Piwik but especially in UsersManager we should be consistent.

Eg when creating a new user it says "login"
image

but the header title says "username"

image
@tsteur tsteur added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. labels Dec 10, 2015
@mattab
Copy link
Member

mattab commented Dec 22, 2015

+1 for using username consistently

@mattab mattab added this to the 3.0.0 milestone Dec 23, 2015
ashleighpearson added a commit to ashleighpearson/piwik that referenced this issue Jan 21, 2016
@ashleighpearson
Use username consistently instead of login matomo-org#9372
ec967dd
@ashleighpearson ashleighpearson mentioned this issue Jan 21, 2016
Merged
mattab pushed a commit that referenced this issue Jan 21, 2016
Merge pull request #9603 from ashleighpearson/9372
dcc9f63 
Use username consistently instead of login #9372
@mattab mattab modified the milestones: 2.16.0, 3.0.0 Jan 21, 2016
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 21, 2016
@mattab
Copy link
Member

mattab commented Jan 21, 2016

fixed in #9603

@mattab mattab closed this as completed Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.16.0
Development

No branches or pull requests
2 participants
@tsteur @mattab