Fix exit page url was not correct when last action was a download or outlink #9343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
Bug
tsteur
force-pushed
the
exit_url_fix
branch
2 times, most recently
from
6399672
to
f4dd52a
Compare
tsteur
added
not-in-changelog
|
@mattab maybe we postpone this change for Piwik 4? Not sure how important it is or whether we at some point want to introduce actions that are "counted as pageview / interaction" |
|
I reckon we should take a look at this PR for beta2 👍 |
|
I've reopened this PR here: #10867 (cherry picked this, made a fix for site search and tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case:
So far Piwik has stored a
visit_exit_idaction_url=example.org/outlinkwith type id2(for outlink). The exit page should be stillexample.com/foo/barthough.Same for downloads. If last action was an outlink or download we did not count an exit for the actual last page.
FYI: The page title was tracked correctly but not the page url
On hold as it requires DB schema changes see #9345