Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not serialize Request::processRequest API request #9318

Merged
merged 1 commit into from Dec 3, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 1, 2015

Otherwise when serialize=1 is set on any URL for controller or API it will fail as it would return the serialized string instead of an expected array or DataTable. In the past we always had to set it manually when using Request::processRequest as all GET + POST params of the initial request are forwarded to this by default. It was not clear that someone had to set serialize=0 each time one does a Request::processRequest.

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 1, 2015
@tsteur tsteur added this to the 2.15.1 milestone Dec 1, 2015
@tsteur
Copy link
Member Author

tsteur commented Dec 1, 2015

The failing UI test in http://builds-artifacts.piwik.org/piwik/piwik/processrequestserialize/16957/
is a random UI test failure

@tsteur tsteur changed the title Do not serialize Reuest::processRequest API request Do not serialize Request::processRequest API request Dec 2, 2015
mattab pushed a commit that referenced this pull request Dec 3, 2015
Do not serialize Request::processRequest API request
@mattab mattab merged commit e4cf508 into master Dec 3, 2015
@mattab mattab deleted the processrequestserialize branch December 3, 2015 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants