New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New segment: ActionType #9314
New segment: ActionType #9314
Conversation
Bug:
|
Created #9326: Delete log_action.type column and move it to: log_link_visit_action.type |
Cannot reproduce this one |
Actually can reproduce it now, not sure why it only happens on some reports |
Should be fixed |
This PR defines a new segment ActionType. This is especially useful when for example viewing a CustomDimensions report in scope Action. By default custom dimensions are tracked across all actions. By using eg a segment
actionType=pageviews
one can see all custom dimensions tracked for pageviews. Or maybe someone wants to see all Custom Dimension values for downloads and outlinks etc.In order to make this work we had to change how event urls are tracked as the segment works on the SQL segment
log_action.type
. So far, when an event was tracked, we looked for a URL having the type1
(Pageview) inlog_action
. To be actually able to segment for events we are now using type10
inlog_action
when request was an event. Downside is we create many more entries inlog_action
for each URL used in an event tracking call. On the good side we now have more accurate statistics in Transition reports where exit rate and referrer are calculated more correctly since they did not differentiate between events and a pageview.We also identified at some point it might be useful to completely remove the
type
column fromlog_action
table and instead store the type of the action inlog_link_visit_action
. This would help to avoid creating many duplicated entries inlog_action
.Re failing tests: