Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New visit after midnight - setting for disabling this characteristic, refs #9156 #9310

Merged
merged 4 commits into from Dec 22, 2015
Merged

New visit after midnight - setting for disabling this characteristic, refs #9156 #9310

merged 4 commits into from Dec 22, 2015

Conversation

peterbo
Copy link
Contributor

@peterbo peterbo commented Nov 30, 2015

Refs #9156

@tsteur
Copy link
Member

tsteur commented Nov 30, 2015

Hi @peterbo :) @mattab do you mind having a look? I'm not so much into this. Code wise it looks good to merge :)

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 30, 2015
@@ -561,6 +561,10 @@
; on a per-request basis;
pivot_by_filter_default_column_limit = 10

; ONLY CHANGE THIS VALUE WHEN YOU DO NOT USE PIWIK ARCHIVING, SINCE THIS COULD CAUSE PARTIALLY MISSING ARCHIVE DATA
; Whether to force a new visit at midnight for every visitor. Default 1.
force_new_visit_midnight = 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we rename to create_new_visit_after_midnight and add it after create_new_visit_when_website_referrer_changes ?

@mattab mattab added this to the 2.15.1 milestone Dec 7, 2015
@mattab
Copy link
Member

mattab commented Dec 18, 2015

Hi @peterbo FYI the build fails with Fatal error: Class 'Piwik\Plugins\CoreHome\Tracker\Config' not found in /home/travis/build/piwik/piwik/plugins/CoreHome/Tracker/VisitRequestProcessor.php on line 157

@peterbo
Copy link
Contributor Author

peterbo commented Dec 18, 2015

Sorry for that - I was 100% sure that I did that change, but somehow the patch didn't find its way to GitHub. Now it should be fixed!

@mattab
Copy link
Member

mattab commented Dec 21, 2015

@peterbo still does not work, please test your patches ;-) PHP Fatal error: Class 'Piwik\Plugins\CoreHome\Tracker\Config' not found in /home/travis/build/piwik/piwik/plugins/CoreHome/Tracker/VisitRequestProcessor.php on line 157

@peterbo
Copy link
Contributor Author

peterbo commented Dec 21, 2015

Ok, now tested in my test-suite. Reminds me of testing even with small patches. Now, all good things come in threes.

mattab pushed a commit that referenced this pull request Dec 22, 2015
 New visit after midnight - setting for disabling this characteristic, refs #9156
@mattab mattab merged commit f0c8c35 into matomo-org:master Dec 22, 2015
@mattab
Copy link
Member

mattab commented Dec 22, 2015

Cheers @peterbo !

@MatomoForumNotifications

This pull request has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/tracking-of-long-visits/53545/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants