New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New visit after midnight - setting for disabling this characteristic, refs #9156 #9310
New visit after midnight - setting for disabling this characteristic, refs #9156 #9310
Conversation
@@ -561,6 +561,10 @@ | |||
; on a per-request basis; | |||
pivot_by_filter_default_column_limit = 10 | |||
|
|||
; ONLY CHANGE THIS VALUE WHEN YOU DO NOT USE PIWIK ARCHIVING, SINCE THIS COULD CAUSE PARTIALLY MISSING ARCHIVE DATA | |||
; Whether to force a new visit at midnight for every visitor. Default 1. | |||
force_new_visit_midnight = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we rename to create_new_visit_after_midnight
and add it after create_new_visit_when_website_referrer_changes
?
Hi @peterbo FYI the build fails with |
Sorry for that - I was 100% sure that I did that change, but somehow the patch didn't find its way to GitHub. Now it should be fixed! |
@peterbo still does not work, please test your patches ;-) |
Ok, now tested in my test-suite. Reminds me of testing even with small patches. Now, all good things come in threes. |
New visit after midnight - setting for disabling this characteristic, refs #9156
Cheers @peterbo ! |
This pull request has been mentioned on Matomo forums. There might be relevant details there: |
Refs #9156