Let Super User view and edit segments created by other users #9307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a Super User: * I can now see all segments that were created for this website by any other user * When a segment was created by another user who is not Super User, the segment appears below a new section "Visible to you because you have Super User access:" * Such segments are editable by the Super User * The only difference when editing someone else's segment, as a Super User, is that "This segment is visible to [ME]" now says "This segment is visible to [SEGMENT_AUTHOR_USERNAME]" * One can now search in the search bar for a username and see all segments created by this user For all users: * New section "Shared with you:" now lists segments created by a Super User, and marked as "Visible to [All Users]" * Before segments shared with me, looked the same as segments I created, which was confusing
mattab
added
not-in-changelog
mattab
added
Pull Request WIP
| @@ -20,10 +20,12 @@ | |||
| "SegmentIsDisplayedForWebsite": "and displayed for", | |||
| "SegmentNotApplied": "Segment '%s' not applied", | |||
| "SegmentNotAppliedMessage": "You are requesting data for the Custom Segment '%s', this Piwik configuration currently prevents real time processing of reports for performance reasons.", | |||
| "SelectSegmentOfVisitors": "Select a segment of visitors:", | |||
| "SelectSegmentOfVisitors": "Select a segment of visits:", | |||
There was a problem hiding this comment.
Maybe we should also change the key in that case, as it would differ from the translation otherwise
|
Notes to self
|
Conflicts: lang/en.json
|
Closed and re-created in #9621 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6766
As a Super User
Visible to you because you have Super User access:This segment is visible to [ME]now saysThis segment is visible to [SEGMENT_AUTHOR_USERNAME]For all users
Shared with you:now lists segments created by a Super User, and marked asVisible to [All Users]screenshot