Forward selected segment to transition in overlay #9301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
tsteur
force-pushed
the
9256_transition
branch
from
25d0bf8
to
6795f49
Compare
tsteur
force-pushed
the
9256_transition
branch
from
6795f49
to
f210d65
Compare
tsteur
added a commit
that referenced
this pull request
Nov 30, 2015
Forward selected segment to transition in overlay
tsteur
added a commit
to matomo-org/plugin-CustomDimensions
that referenced
this pull request
Dec 1, 2015
…n popup with segment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #9129 #9256
In #9129 I added the feature to apply a segment to overlay. This PR will forward the segment to the transition popup when clicking on the transition link in the left sidebar of the overlay page.
FYI: I tried to forward segment to row action as well but this would be lots of work and is not trivial.
I need this method (
DataTable_RowActions_Transitions.launchForUrl(iframeCurrentPageNormalized, segment) in other plugins as well