Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiny: 2.15.1b5 dashboard/widget/entry pages does not use label #9283

Closed
hpvd opened this issue Nov 26, 2015 · 5 comments
Closed

tiny: 2.15.1b5 dashboard/widget/entry pages does not use label #9283

hpvd opened this issue Nov 26, 2015 · 5 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Milestone
Backlog (Help wan...

Comments

@hpvd
Copy link

hpvd commented Nov 26, 2015

tiny: 2.15.1b5 dashboard/widget/entry pages seems not to use label
please see attachment
2015-11-26_07h12_20
@tsteur
Copy link
Member

tsteur commented Nov 26, 2015

FYI: This is the Insights report (took me a while to be able to reproduce it). It's also happening with Beta 3 on demo.piwik.org. Might be not a new regression in 2.15?

@tsteur tsteur added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Nov 26, 2015
@tsteur tsteur added this to the 2.15.1 milestone Nov 26, 2015
@tsteur
Copy link
Member

tsteur commented Nov 26, 2015

Quickly tried to fix it but not sure why it doesn't work anymore. It seems like it never worked for this report possibly. Problem is metricName is not translated in DataTableMetadata in https://github.com/piwik/piwik/blob/master/plugins/Insights/InsightReport.php#L222-L224 There is no report metadata translation for metric nb_visits as report metadata contains translations for entry_nb_visits and entry_bounce_count (which is correct).

nb_visits has always been hard coded here I think: https://github.com/piwik/piwik/blob/2.15.0/plugins/Insights/API.php#L207

@hpvd do you know if it worked in 2.14?

@hpvd
Copy link
Author

hpvd commented Nov 26, 2015

thanks!
hmm do not know exactly when it appears: have never seen it before. Saw it the first time today...

@tsteur
Copy link
Member

tsteur commented Nov 30, 2015

Actually, I'll replace the label regression with bug since I can't see how it ever worked :) @mattab I'll also clear the milestone

@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. and removed Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Nov 30, 2015
@tsteur tsteur removed this from the 2.15.1 milestone Nov 30, 2015
@mattab mattab added this to the Short term milestone Dec 23, 2015
@tsteur tsteur mentioned this issue Jul 24, 2016
Closed
@hpvd
Copy link
Author

hpvd commented Sep 14, 2017

seems to be solved.

@hpvd hpvd closed this as completed Sep 14, 2017
@mattab mattab added the worksforme The issue cannot be reproduced and things work as intended. label Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@tsteur @mattab @hpvd