@hpvd opened this Issue on November 26th 2015

tiny: 2.15.1b5 dashboard/widget/entry pages seems not to use label
please see attachment

@tsteur commented on November 26th 2015 Member

FYI: This is the Insights report (took me a while to be able to reproduce it). It's also happening with Beta 3 on demo.piwik.org. Might be not a new regression in 2.15?

@tsteur commented on November 26th 2015 Member

Quickly tried to fix it but not sure why it doesn't work anymore. It seems like it never worked for this report possibly. Problem is metricName is not translated in DataTableMetadata in https://github.com/piwik/piwik/blob/master/plugins/Insights/InsightReport.php#L222-L224 There is no report metadata translation for metric nb_visits as report metadata contains translations for entry_nb_visits and entry_bounce_count (which is correct).

nb_visits has always been hard coded here I think: https://github.com/piwik/piwik/blob/2.15.0/plugins/Insights/API.php#L207

@hpvd do you know if it worked in 2.14?

@hpvd commented on November 26th 2015

hmm do not know exactly when it appears: have never seen it before. Saw it the first time today...

@tsteur commented on November 30th 2015 Member

Actually, I'll replace the label regression with bug since I can't see how it ever worked :) @mattab I'll also clear the milestone

@hpvd commented on September 14th 2017

seems to be solved.

This Issue was closed on September 14th 2017
Powered by GitHub Issue Mirror