Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute System tests over HTTP instead of in the same process #9277

Closed
wants to merge 6 commits into from

Conversation

mattab
Copy link
Member

@mattab mattab commented Nov 25, 2015

fixes #9271

Notes:

  • Many System tests are actually now not returning the "expected" values. This should be fixed.
  • all test files that are actually still correct have been committed to this PR (with small differences such as idsubdatatable

@diosmosis will need your help on this one to tackle the few system tests that now return different values :)

@mattab mattab added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Nov 25, 2015
@mattab mattab added this to the 2.15.1 milestone Nov 25, 2015
<row>_pkp</row>
<row>_pk_scount</row>
<row>_pk_scat</row>
<error message="The method 'getReservedCustomVariableKeys' does not exist or is not available in the module '\Piwik\Plugins\CustomVariables\API'." />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those API that are tagged @ignore actually can't be called via HTTP which is acceptable. ideally we should remove these test cases.

@mattab mattab added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Nov 25, 2015
diosmosis added 4 commits November 25, 2015 08:22
… disabled across processes. One test appears to have been broken before (more data appears now), but I can't say why it didn't work before.
@mattab
Copy link
Member Author

mattab commented Dec 4, 2015

Would it maybe work if we moved the remaining System tests that don't work over HTTP as "integration tests" instead, issued via FrontController as previously?

@mattab mattab modified the milestone: 2.15.1 Dec 4, 2015
@mattab mattab added this to the 3.0.0 milestone Dec 23, 2015
@tsteur tsteur changed the base branch from master to 2.x-dev September 1, 2016 06:39
@mattab
Copy link
Member Author

mattab commented Sep 23, 2016

No time to fix this for now, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant