Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the length of the plugin name when generating a plugin #9275

Closed
tsteur opened this issue Nov 25, 2015 · 0 comments
Closed

Limit the length of the plugin name when generating a plugin #9275

tsteur opened this issue Nov 25, 2015 · 0 comments
Assignees
Labels
answered For when a question was asked and we referred to forum or answered it. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.

Comments

@tsteur
Copy link
Member

tsteur commented Nov 25, 2015

Ideally we would also check the length when someone wants to publish a plugin on the marketplace but think it is not needed since we always recommend to use generate:plugin.

Background: If the plugin name is too long we won't be able to execute UI tests or possibly even System tests. When executing the UI tests for a plugin we create a new database in the format of $pluginName_$fixtureName. MySQL limits the number of allowed characters for a database name to 64. So if the plugin name is already 50 characters long one doesn't have many characters left for a possible fixture name. If plugin name is >= 64 characters one cannot create UI tests at all.

I'd suggest to limit plugin name to 40 characters max. At least in the plugin generator. 40 characters should be long enough to define a meaningful plugin name (such as PageUrlReportWithoutExtractedValue which has 35 characters)

@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Nov 25, 2015
@mattab mattab added this to the Short term milestone Nov 25, 2015
halfdan added a commit that referenced this issue Dec 26, 2015
@halfdan halfdan self-assigned this Dec 26, 2015
tsteur added a commit to matomo-org/developer-documentation that referenced this issue Jan 10, 2016
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Development

No branches or pull requests

3 participants