Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API System tests are not actual system tests #9271

Closed
tsteur opened this issue Nov 24, 2015 · 0 comments
Closed

API System tests are not actual system tests #9271

tsteur opened this issue Nov 24, 2015 · 0 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
Priority Backlog ...

Comments

@tsteur
Copy link
Member

tsteur commented Nov 24, 2015

The system tests are not actually executed via HTTP but via API\Request::processRequest() in the same environment as the tests run in https://github.com/piwik/piwik/blob/2.15.1-b2/tests/PHPUnit/Framework/TestCase/SystemTestCase.php#L299

The point of system tests (or end-to-end tests) is to actually test the system from outside via HTTP. Otherwise it is kinda just an integration test. Either we should actually execute them via HTTP (even if it'll take a bit longer) or we should move them to IntegrationTests as it otherwise leads to wrong expectations.
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. labels Nov 24, 2015
@mattab mattab mentioned this issue Nov 25, 2015
Closed
@mattab mattab added this to the 2.15.1 milestone Nov 25, 2015
@mattab mattab modified the milestone: 2.15.1 Dec 4, 2015
@mattab mattab added this to the 3.0.0 milestone Dec 23, 2015
@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
Priority Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@tsteur @mattab @sgiehl