Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes single quote bug in rowevolution #9241

Merged
merged 2 commits into from Dec 3, 2015
Merged

fixes single quote bug in rowevolution #9241

merged 2 commits into from Dec 3, 2015

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 19, 2015

unsanitize label for row evolution (fixes #8393)

the displayed label in row evolution is given as get param. Maybe due to changes in the history service it might be escaped now, so we need to unsanitize before using it.

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 19, 2015
@sgiehl sgiehl added this to the 2.15.1 milestone Nov 19, 2015
@mattab
Copy link
Member

mattab commented Nov 20, 2015

Feedback:

  • Let's add a UI test to catch this regression in the future
    (Row evolution for a label with & is a key functionnality of Piwik since most URLs will have ampersand 👍 )

@sgiehl
Copy link
Member Author

sgiehl commented Nov 22, 2015

I've added ' and " to a fixture, so it will get used in the rowevolution ui test.
Unfortunately I was not able to easily update the OmniFixture. I used the command mentioned on https://github.com/piwik/piwik/tree/master/tests#keep-omnifixture-up-to-date

./console tests:setup-fixture OmniFixture --sqldump=OmniFixture-dump.sql

but it throws a fatal error. Tried to fix it, but that ended with some other exceptions...

@mattab @diosmosis would you mind checking why the command doesn't work anymore? It seems the Fixture classes are not loaded correctly...

@mattab
Copy link
Member

mattab commented Nov 23, 2015

@sgiehl there was already & in the UI test, does it mean this bug should have been caught (and was caught) by UI tests? did we maybe miss it when the screenshot changed?

@sgiehl
Copy link
Member Author

sgiehl commented Nov 23, 2015

No, the problem occurred with '. & was already covered.

@diosmosis
Copy link
Member

This fixes the OmniFixture issues for me: #9262

@sgiehl
Copy link
Member Author

sgiehl commented Nov 23, 2015

Oh. Updating the OmniFixture makes a lot of UI tests fail... It's hard to check which ones are expected.

@mattab
Copy link
Member

mattab commented Nov 23, 2015

@sgiehl could you maybe update omnifixture in a separate PR and we can more easily check if changes are expected? I can help check screenshots if needed

@sgiehl
Copy link
Member Author

sgiehl commented Nov 23, 2015 via email

@sgiehl
Copy link
Member Author

sgiehl commented Nov 24, 2015

Reverted the Omnifixture update. Will create a separate PR for that soon. Guess this one can be merged then?

@mattab
Copy link
Member

mattab commented Nov 27, 2015

@sgiehl there is still changes to omnifixture in the PR, is it expected?

@sgiehl
Copy link
Member Author

sgiehl commented Nov 27, 2015 via email

@sgiehl
Copy link
Member Author

sgiehl commented Nov 27, 2015

Now it should be fine.

@mattab
Copy link
Member

mattab commented Dec 3, 2015

Works 👍

mattab pushed a commit that referenced this pull request Dec 3, 2015
fixes single quote bug in rowevolution
@mattab mattab merged commit 0dc59b9 into master Dec 3, 2015
@mattab mattab deleted the 8393 branch December 3, 2015 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants