New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes single quote bug in rowevolution #9241
Conversation
Feedback:
|
36fb3b0
to
5054f4c
Compare
I've added
but it throws a fatal error. Tried to fix it, but that ended with some other exceptions... @mattab @diosmosis would you mind checking why the command doesn't work anymore? It seems the Fixture classes are not loaded correctly... |
@sgiehl there was already |
No, the problem occurred with |
This fixes the OmniFixture issues for me: #9262 |
Oh. Updating the OmniFixture makes a lot of UI tests fail... It's hard to check which ones are expected. |
@sgiehl could you maybe update omnifixture in a separate PR and we can more easily check if changes are expected? I can help check screenshots if needed |
I'll do that tomorrow.
|
Reverted the Omnifixture update. Will create a separate PR for that soon. Guess this one can be merged then? |
@sgiehl there is still changes to omnifixture in the PR, is it expected? |
No. Need to remove that too...
|
Now it should be fine. |
Works 👍 |
fixes single quote bug in rowevolution
unsanitize label for row evolution (fixes #8393)
the displayed label in row evolution is given as get param. Maybe due to changes in the history service it might be escaped now, so we need to unsanitize before using it.