Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page Overlay doesn't check the port in the URL #9240

Open
shenzhuxi opened this issue Nov 19, 2015 · 1 comment
Open

Page Overlay doesn't check the port in the URL #9240

shenzhuxi opened this issue Nov 19, 2015 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Milestone
For Prioritization

Comments

@shenzhuxi
Copy link

In Page Overlay view, url with port will not be displayed.

I fixed it in piwik/plugins/Overlay/client/urlnormalizer.js with

        initialize: function () {
-            this.setCurrentDomain(document.location.hostname);
+           this.setCurrentDomain(document.location.hostname + ':' + document.location.port);
            this.setCurrentUrl(window.location.href);

            var head = document.getElementsByTagName('head');
            if (head.length) {
                var base = head[0].getElementsByTagName('base');
                if (base.length && base[0].href) {
                    this.setBaseHref(base[0].href);
                }
            }
        },
@tsteur
Copy link
Member

tsteur commented Nov 22, 2015

Hi @shenzhuxi are you maybe familiar with pull requests and want to issue one?

If so, it should append the port only if there is a port actually set

@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Nov 22, 2015
@mattab mattab added this to the Short term milestone Nov 25, 2015
@mattab mattab added the Needs Review PRs that need a code review label Feb 13, 2020
@mattab mattab removed this from the Backlog (Help wanted) milestone Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
4 participants
@tsteur @mattab @shenzhuxi @innocraft-automation