Fix no data in segmented visitor log for urls with ampersand #9230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
mattab
pushed a commit
that referenced
this pull request
Nov 23, 2015
Fix no data in segmented visitor log for urls with ampersand
|
Works 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9192
In #7220 we fixed that URLs were sometimes stored encoded and sometimes not. This was about 9 months ago. Meanwhile most URLs should be actually stored correctly and therefore we no longer need to unsanitize the URL when applying the page url segment. It worked at least fine for me this way.
I remember a conversation in February where we talked about the need to change something eg 6 months after the change in #7220 but I forgot what it was and couldn't find an issue for that.