Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console generator: Do not automatically convert first character to uppercase #9209

Merged
merged 2 commits into from Nov 17, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 12, 2015

A plugin does not have to start with an uppercase. There are even plugins on the marketplace with a lower letter see eg http://plugins.piwik.org/cacheBuster

FYI: The plugin generator still does a ucfirst on the plugin name so new plugins will be named with a letter case automatically which should be the recommended way.

@tsteur tsteur added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Nov 12, 2015
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Nov 12, 2015
@tsteur tsteur added this to the 2.15.1 milestone Nov 12, 2015
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Nov 12, 2015
mattab pushed a commit that referenced this pull request Nov 17, 2015
Console generator: Do not automatically convert first character to uppercase
@mattab mattab merged commit bf5bd78 into master Nov 17, 2015
@mattab mattab deleted the plugin_generator_fix_lowercase branch November 18, 2015 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants