New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Free Mobile support #9208
Add Free Mobile support #9208
Conversation
$getExtendedInfo = true | ||
); | ||
|
||
if (false === $result) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not trigger a notification in this case. It might not even really work when they are sent in the background eg via a cronjob. Do you mind removing the notification part? We'd rather implement this in the core itself at some point so it will work the same way for all SMS providers. Currently, the other clockwork provider does not post any notifications.
Thx for the PR! I couldn't try it myself. Is there a possibility to test it somehow without having an actual account? @mattab @julienmoumne does one of you maybe have an account? @mattab Should this be in core? We could quite easily make this an API so users can add providers via a plugin. If we have it in core we need to support and test it regularly etc. |
I don't have an account to test, maybe @julienmoumne ?
Ideally this SMS provider would be added in a new plugin on the Marketplace, because most users cannot use it since it requires an account with Free. @tsteur maybe such capability could be added for 2.15.1 if it is rather trivial? |
@apapillon we really appreciate your effort to define a new SMS provider. We developed a new API so more users can define more SMS providers in the future in #9226 . It is not yet merged but should be soon. To create a new custom SMS Provider all you have to do is to create a new plugin see http://developer.piwik.org/guides/getting-started-part-1#create-a-plugin eg via Next put your FreeMobile SMS Provider class that you have created into the Afterwards you could publish the plugin on the marketplace see http://piwik.org/blog/2014/09/publish-plugin-theme-piwik-marketplace-introducing-piwik-platform/ or for more details http://developer.piwik.org/guides/distributing-your-plugin . Are you keen re creating such a plugin? |
Note: the plugin would require Piwik 2.15.1-b2 which was just released few minutes ago. When you create the plugin please set the required piwik version to |
Hi, |
Thx a lot @apapillon You won't have to create a new PR. You can create a new plugin yourself under your account, push the plugin to that repository similar to https://github.com/tsteur/piwik-livetab-plugin (in your case it would contain only a few files and the directory |
A proposition for add Free Mobile support on MobileMessaging #9207