Better check for valid plugin names #9173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
|
👍 |
mattab
pushed a commit
that referenced
this pull request
Nov 6, 2015
Better check for valid plugin names
mattab
pushed a commit
that referenced
this pull request
Nov 6, 2015
|
fyi: added note in developer changelog fe9cdef |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9171
First I hesitated to make this change in plugin manager as well and not only in the plugin generator as I was afraid of breaking existing plugins. On the other side a plugin starting with a number or containing a
-or.could not have worked before as it wouldn't be a valid plugin name.If it is still too risky as there could be a plugin not defining a
Pluginclass then we can remove the check inPlugin\Manageragain.I also thought about forcing a capital letter first but this would actually break plugin names.
FYI: I already adjusted the check in Marketplace, will update the server soon and also check for developer.piwik.org