Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate:plugin should control the name provided against an appropriate regex #9171

Closed
abouquet opened this issue Nov 5, 2015 · 2 comments
Closed

generate:plugin should control the name provided against an appropriate regex #9171

abouquet opened this issue Nov 5, 2015 · 2 comments
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.16.0

Comments

@abouquet
Copy link

abouquet commented Nov 5, 2015

When generating a new plugin, i've created a new one containing "-" character following the example

php console generate:plugin --name="My-Plugin"

The problem is that the name of the plugin is used to generate a php class file which isn't compatible with naming rules
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Nov 5, 2015
@tsteur tsteur added this to the 2.15.1 milestone Nov 5, 2015
@tsteur tsteur self-assigned this Nov 5, 2015
tsteur added a commit that referenced this issue Nov 5, 2015
@tsteur
refs #9171 better check for valid plugin names
38b769a
@tsteur tsteur mentioned this issue Nov 5, 2015
Merged
@tsteur
Copy link
Member

tsteur commented Nov 5, 2015

This is a very good find, thx! I issues a pull request to fix it (#9173) and I'm also updating the Marketplace and docs

tsteur added a commit to matomo-org/developer-documentation that referenced this issue Nov 5, 2015
@tsteur
refs matomo-org/matomo#9171 fix allowed plugin name characters
1240900
@abouquet
Copy link
Author

abouquet commented Nov 6, 2015

Thx for your quick fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.16.0
Development

No branches or pull requests
2 participants
@tsteur @abouquet