Use MySQL instead of SQLite in tracker tests #9164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
Pull Request WIP
mattab
pushed a commit
that referenced
this pull request
Nov 5, 2015
Use MySQL instead of SQLite in tracker tests
|
Very nice, it's also faster on my machine 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9163
For now I'm using hardcoded database
tracker_testswhich will be generated dynamically if it does not exist yet. Maybe we should configure it? Thought it's maybe no problem as we already generate randomly any databases during UI tests etc.If Piwik is not installed yet or
[database_test]section is not configured we get same warnings as when running PHPUnit tests.After merge we could also get rid of https://github.com/piwik/travis-scripts/blob/5c1208d725916d21e47527c8d7281af52a5bb5f7/travis.sh#L25