Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SQLite dependency in tracker tests #9163

Closed
tsteur opened this issue Nov 4, 2015 · 2 comments
Closed

Remove SQLite dependency in tracker tests #9163

tsteur opened this issue Nov 4, 2015 · 2 comments
Assignees
@tsteur
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Milestone
2.16.0

Comments

@tsteur
Copy link
Member

tsteur commented Nov 4, 2015

To run Tracker tests via http://$domain/tests/javascript/ one needs to have SQLite installed. It would be good to remove this dependency if possible and use eg MySQL instead or a plain text file if possible.
We already have credentials for MySQL so this should be possible.

In the past I've always had some trouble getting SQLite to work and now PHPBrew I don't get it to work at all as I'm always getting an error when installing the extension and I cannot solve it. Meaning I cannot write tracker tests needed for custom dimensions etc.

It would be nice to reuse existing dependencies here (to be clear: MySQL). Does maybe anyone remember why we chose SQLite for this?
@tsteur tsteur added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. labels Nov 4, 2015
@diosmosis
Copy link
Member

Looks like all it does is insert rows & do two simple queries. Could probably replace it w/ a text file.

@tsteur
Copy link
Member Author

tsteur commented Nov 4, 2015

I'm just working on supporting MySQL and it pretty much works. There are some queries for token_auth so text file wouldn't be really so good.

@tsteur tsteur self-assigned this Nov 4, 2015
@tsteur tsteur added this to the 2.15.1 milestone Nov 4, 2015
tsteur added a commit that referenced this issue Nov 4, 2015
@tsteur
refs #9163 use mysql instead of sqlite in tracker tests
68d3487
@tsteur tsteur mentioned this issue Nov 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Projects
None yet
Milestone
2.16.0
Development

No branches or pull requests
2 participants
@diosmosis @tsteur