Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close button icon in popovers has poor contrast #9155

Closed
hpvd opened this issue Nov 3, 2015 · 0 comments
Closed

Close button icon in popovers has poor contrast #9155

hpvd opened this issue Nov 3, 2015 · 0 comments
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
2.16.0

Comments

@hpvd
Copy link

hpvd commented Nov 3, 2015

in popups, the colour of the cross in close buttons has poor contrast to the red background.
=> white or light grey would be better

please see attachment
2015-11-03_10h43_31
@mattab mattab added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Nov 25, 2015
@mattab mattab added this to the Short term milestone Nov 25, 2015
@mattab mattab added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Nov 25, 2015
@ghost ghost mentioned this issue Jan 19, 2016
Merged
tsteur added a commit that referenced this issue Jan 19, 2016
@tsteur
Merge pull request #9572 from RobotHoboDanceParty/9155
dfc8d13 
colour of cross in close buttons has poor contrast #9155.
mattab added a commit that referenced this issue Jan 20, 2016
@mattab
UI tests: Contrast for close button #9572 #9155
cb792eb
@mattab mattab changed the title tiny: colour of cross in close buttons has poor contrast Close button icon in popovers has poor contrast Jan 30, 2016
@mattab mattab modified the milestones: 2.16.0, Mid term Jan 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
2.16.0
Development

No branches or pull requests
2 participants
@mattab @hpvd