Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WAI-ARIA features to main menu for better accessibility #9148

Closed
tassoman opened this issue Nov 2, 2015 · 8 comments
Closed

Add WAI-ARIA features to main menu for better accessibility #9148

tassoman opened this issue Nov 2, 2015 · 8 comments
Labels
answered For when a question was asked and we referred to forum or answered it. c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones).

Comments

@tassoman
Copy link
Contributor

tassoman commented Nov 2, 2015

According to Using ARIA menus WCAG WorkGroup at W3G and our Accessibility analisys, Piwik's menu should use role attribute using menu, menuitem values.

@mattab
Copy link
Member

mattab commented Nov 2, 2015

👍

refs #4167

@mattab
Copy link
Member

mattab commented Nov 26, 2015

Hi @tassoman was this issue fixed in your PR #9149 or is there more work to do?

@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Nov 26, 2015
@mattab mattab added this to the Short term milestone Nov 26, 2015
@tassoman
Copy link
Contributor Author

Focusing on main menu, things are almost done for now.
Mr @jdeyla and I are facing issues with NVDA and JAWS screen readers, they're working in different ways on Dashboard's ready moment, NVDA looks like award of page fulfillment (after widget load), JAWS still unaware, the link "skip to content" brings navigation to the empty div tag.

In the end I think this is a different issue on a11y and may be a future PR. Such as "second menu" (horizontal) WAI-ARIA integration, will be.

There still unanswered a question opened with Core Dev Team on #7589, do you agree with Mr @jdeyla suggestions? (ref. comment nr. 144698624)

@mattab
Copy link
Member

mattab commented Nov 27, 2015

There still opened a question opened with Core Dev Team on #7589, do you agree with Mr @jdeyla suggestions? (ref. comment nr. 144698624)

This issue is closed, maybe you could create a new one or post here the feedback?

@tassoman
Copy link
Contributor Author

Sorry for misunderstanding I was meaning that when he argued with menuitems low contrast visibility was 1st Oct. then you closed on 7th :)

Do you think we should open a new issue on it?

@tassoman
Copy link
Contributor Author

In the user navbar there's the profile link. Screen readers reads this link only as user's Alias field value.
The best would be read a multi language translation of "Alias's personal settings" but I have no clue how to edit translations that are stored on Transifex 🇮🇹 🇫🇷 🇬🇧

@sgiehl
Copy link
Member

sgiehl commented Nov 30, 2015

Simply change the english default text in the english translation files on git. Transifex will automatically update the source and remove already available translations so they get translated again.

@tassoman
Copy link
Contributor Author

I've managed it without adding any new translation string 😎
I think this topic could be closed for now 😄

@mattab mattab added c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). and removed c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Jan 20, 2016
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones).
Projects
None yet
Development

No branches or pull requests

3 participants