Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when PHP is 5.4, display a warning message notifying users to upgrade to PHP 5.5 #9144

Merged
merged 3 commits into from Nov 4, 2015

Conversation

mattab
Copy link
Member

@mattab mattab commented Nov 2, 2015

refs #8156 #8193

@mattab mattab added the Needs Review PRs that need a code review label Nov 2, 2015
@mattab mattab added this to the 2.15.1 milestone Nov 2, 2015
$majorPhpVersion = '5.3';
} elseif(self::isPhpVersion54()) {
$majorPhpVersion = '5.4';
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe put this up to the beginning and check for $majorPhpVersion !== null && Piwik::hasUserSuperUserAccess()? This way the outdated version doesn't have to be maintained in two places (before and after notifyPhpIsEOL).

Or maybe only check if it's at least PHP5.5 and if not show phpversion()?

@tsteur
Copy link
Member

tsteur commented Nov 3, 2015

Good to merge, left a comment but not neccessary

@mattab
Copy link
Member Author

mattab commented Nov 3, 2015

Applied suggested change

tsteur added a commit that referenced this pull request Nov 4, 2015
when PHP is 5.4, display a warning message notifying users to upgrade to PHP 5.5
@tsteur tsteur merged commit 71c972d into master Nov 4, 2015
@tsteur tsteur deleted the notification_old_php branch November 4, 2015 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants