Use window.JSON only if it actually contains JSON API methods stringify and parse #9142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods stringify and parse
tsteur
added
not-in-changelog
mattab
pushed a commit
that referenced
this pull request
Nov 2, 2015
Use window.JSON only if it actually contains JSON API methods stringify and parse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9130
When the builtin / native browser JSON API is available we use this one as it is much faster and should be more stable.
In this case the user overwrote
window.JSONwith a custom object likevar JSON = {encode: function..., decode: function...}. We need to check whether thestringifyandparsemethod is actually available