Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display warning during Piwik update, if the config file is not writable #9128

Closed
mattab opened this issue Oct 30, 2015 · 4 comments
Closed

Display warning during Piwik update, if the config file is not writable #9128

mattab opened this issue Oct 30, 2015 · 4 comments
Assignees
@mattab
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. duplicate For issues that already existed in our issue tracker and were reported previously.
Milestone
2.16.3

Comments

@mattab
Copy link
Member

mattab commented Oct 30, 2015

When the config file is not writable during an ugprade, some of the config file updates are not applied. For example in a recent Piwik version we introduced new plugin Monolog, and this plugin was activated during the Upgrade. When the config file is not writable, the plugin cannot be activated, resulting in a partly broken Piwik instance (where logging does not work).

Suggested: when the config file is not writable and there is some update to execute,

  • either issue a warning to the user to explain that the config file should be writable for the time of the upgrade,
  • or issue an error message to prevent user from proceeding to the upgrade

follows up #9103 (comment) and many similar issues.
@mattab mattab mentioned this issue Oct 30, 2015
Closed
@mattab mattab added this to the 3.0.0 milestone Nov 26, 2015
@mattab
Copy link
Member Author

mattab commented Nov 26, 2015

This will prevent serious bugs in the future 👍

@tsteur tsteur mentioned this issue Jan 27, 2016
Closed
@tsteur
Copy link
Member

tsteur commented Jan 27, 2016

See #9623 we should ideally also check whether tmp / cache directory is writable in order to clear the cache.

@alphaonex86
Copy link

Purge it and if unable to purge (remove failed) then display an error.

@mattab mattab modified the milestones: 2.16.x, 3.0.0 Feb 8, 2016
@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Feb 8, 2016
@mattab mattab modified the milestones: 2.16.3, 2.16.x (LTS) Jul 18, 2016
@mattab mattab mentioned this issue Aug 23, 2016
Merged
@mattab mattab self-assigned this Aug 23, 2016
@mattab
Copy link
Member Author

mattab commented Sep 29, 2016

Done in #10423

@mattab mattab closed this as completed Sep 29, 2016
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Milestone
2.16.3
Development

No branches or pull requests
3 participants
@tsteur @mattab @alphaonex86