Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach official release package to GitHub releases #9126

Closed
tsteur opened this issue Oct 29, 2015 · 6 comments
Closed

Attach official release package to GitHub releases #9126

tsteur opened this issue Oct 29, 2015 · 6 comments
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@tsteur
Copy link
Member

tsteur commented Oct 29, 2015

Some users go to GitHub releases to download the Piwik ZIP see #9097 (comment). Those ZIP files seem to include all files though which makes it as "bad" and "complicated to use" (composer, ...) as using it directly via Git which is not recommended.

Instead it would be good to have the official package there which doesn't include the test files, the plugins that are not needed etc. If this is not possible we should check if there's a way to disable downloads there. This might also avoid some random issues in the future.

Wasn't sure if it belongs to https://github.com/piwik/piwik-package/issues . Feel free to move

@mattab
Copy link
Member

mattab commented Oct 29, 2015

The release on Github is not created with a script but is created manually (in two clicks using Releases > New), just prior to running the script to package the build https://github.com/piwik/piwik-package/blob/master/scripts/build-package.sh

to attach the files automatically to the github release, we'd need to use Github API.
Alternatively we could add a link in the release notes on Github to point the ZIP packaged URL in builds.piwik.org/piwik-x.y.zip

@Joey3000
Copy link
Contributor

Joey3000 commented Nov 2, 2015

#9091 is another example of someone downloading from Github instead of builds.piwik.org.

Alternatively we could add a link in the release notes on Github to point the ZIP packaged URL in builds.piwik.org/piwik-x.y.zip

Maybe that could be added to the release notes of the already released Piwik 2.15.0, to help prevent such issues from popping up with the current release? (The notes can be modified post-release.)

@tsteur
Copy link
Member Author

tsteur commented Nov 2, 2015

Thx! I updated https://github.com/piwik/piwik/releases/tag/2.15.0

Maybe we can do something like this easily in the build script. That would be helpful

@Joey3000
Copy link
Contributor

Joey3000 commented Nov 2, 2015

@tsteur Thanks! Just one minor thing: Both added download links support HTTPS. Could they be changed to https://?

Note: The download link on the https://piwik.org/download/ page does not use HTTPS, but that's something for #8236 (comment).

@mattab
Copy link
Member

mattab commented Nov 2, 2015

I've changed links to https and updated the "Release 2.15.0 checklist" to include this new step: #8787

(So we'll remember to do it for next release)

@mattab
Copy link
Member

mattab commented Nov 26, 2015

as you can see in Piwik 2.15.1 release checklist in #9236, there is now a step to update the Github release page to link to the builds. This should fix this issue, thanks for suggesting!

@mattab mattab closed this as completed Nov 26, 2015
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

No branches or pull requests

3 participants