Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

piwik.js - throws error when used in xulrunner #9125

Closed
dikaso opened this issue Oct 29, 2015 · 1 comment
Closed

piwik.js - throws error when used in xulrunner #9125

dikaso opened this issue Oct 29, 2015 · 1 comment
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
2.16.0

Comments

@dikaso
Copy link

dikaso commented Oct 29, 2015

Hello,

I want to use piwiki in my xulrunner application. In xulrunner envinroment document.domain is set as null and can't be changed. Trying to do splice on document.domain will throw error.

Error thrown by xulrunner.

Timestamp: 29.10.2015 19:42:15
Error: TypeError: hostName is null
Source File: https://domain.com/piwik/js/piwik.js
Line: 1547

And this is line when problem occurs.

 hostName.slice(0, 5) === '74.6.') {
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Oct 29, 2015
@tsteur tsteur added this to the 2.15.1 milestone Oct 29, 2015
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Oct 29, 2015
@mattab
Copy link
Member

mattab commented Oct 29, 2015

Hi @DinkoMiletic Thanks for the report!

maybe you know JavaScript and can open a pull request to fix this issue, we'd welcome this :-)

@mattab mattab changed the title piwiki.js - throws error when used in xulrunner piwik.js - throws error when used in xulrunner Oct 30, 2015
@tsteur tsteur self-assigned this Nov 16, 2015
tsteur added a commit that referenced this issue Nov 16, 2015
@tsteur
refs #9125 location.domain is not set when used in xulrunner
1a8297e
@tsteur tsteur mentioned this issue Nov 16, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
2.16.0
Development

No branches or pull requests
3 participants
@tsteur @mattab @dikaso