Make sure to return correct IP when all IPs are excluded #9099
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #8721
I tried to reproduce #8721 with the given server data from #8721 (comment)
I did not get
0.0.0.0
but it returned82.197.211.195, 82.197.211.195
which is wrong as well as it should be82.197.211.195
.Problem was it called
In this case it returned
82.197.211.195, 82.197.211.195
as it did detect there were multiple IPs given but then returned the same$csv
as non of them were allowed. The$defaultIp
was the same as the ones specified in other headers from:In the users case it was actually not needed to specify multiple
proxy_client_headers
. I'm not sure if it will actually fix the issue but it was a bug