Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow switching to 24h format for languages with AM/PM formatted timestamps as default #9082

Closed
basvdijk opened this issue Oct 22, 2015 · 4 comments
Assignees
Labels
answered For when a question was asked and we referred to forum or answered it. c: i18n For issues around internationalisation and localisation. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@basvdijk
Copy link

Since the latest upgrade of Piwik the Visitors in realtime is showing the timestamps as:
Thursday, October 22, - 11:14:25 PM instead of Thursday, October 22, - 23:14:25

@Glisse1
Copy link

Glisse1 commented Oct 23, 2015

Hello, I have posted a thread in forums yesterday for exactly this bug, but i figured i should create a ticket instead. As i can see somebody else already did :)

This is a regression, prior to 2.15 upgrade i have had my time in 24-hour mode. Now, regardless of timezone i tried to change in administration--> website (tried utc, several other cities around the world, again my own city which used to work, etc) the time is always formatted as am/pm

Tried to hack visitor.serverTimePretty which outputs the localized time myself, with no luck.

This does not affect only the real-time widget but every other report and page that outputs the time of an action or visit, like the full Visitor Log report.

Regards.

@sgiehl
Copy link
Member

sgiehl commented Oct 23, 2015

That is based on the language. When you are using are language that uses AM/PM as default.
We may include a setting to switch that later.

@Glisse1
Copy link

Glisse1 commented Oct 23, 2015

OK, solved for now by changing the language, but i dont think is the right way to go. Many users are facing this change all of a sudden just by upgrading to latest version. I used to have 24 hours while in english.

As for me, after 30 years of having no translations in my mother-tongue, english is so much more natural to me, i really prefer it... so yeah, a switch or a setting somewhere in admin settings "use 24 hours instead of am/pm" would be very nice to have 👍

PS: very nice upgrade overall in 2.15, i really like the left menu design, the improved mobile version of the site, kudos!

@basvdijk
Copy link
Author

I am from the Netherlands but still prefer English for software. I agree with @Glisse1 that a setting would be nice to have.

@sgiehl sgiehl changed the title Visitors in realtime shows AM/PM formatted timestamps instead of 24h format Allow switching to 24h format for languages with AM/PM formatted timestamps as default Oct 23, 2015
@sgiehl sgiehl added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. c: i18n For issues around internationalisation and localisation. labels Oct 23, 2015
@sgiehl sgiehl self-assigned this Oct 23, 2015
@sgiehl sgiehl added this to the 2.15.1 milestone Oct 25, 2015
mattab added a commit that referenced this issue Oct 30, 2015
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Jan 30, 2016
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. c: i18n For issues around internationalisation and localisation. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

4 participants