Tracker configId should be based on original IP, not on anonymised IP? #9064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
mattab
pushed a commit
that referenced
this pull request
Oct 20, 2015
Tracker configId should be based on original IP, not on anonymised IP?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7778
The fix is not ideal since it is code in core that accesses code from a plugin. Ideally, at some point, we would handle this logic only once right at the beginning, modify the IP based on
useAnonymizedIpForVisitEnrichmentsetting and use the correct one everywhere. So we would not have to add this check foruseAnonymizedIpForVisitEnrichmentin various places and it would also work for other plugins out of the box