In NumberFormatter::format() check for percent if value is a string #9062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly, since only strings will have a % (avoids floating point issues). Also, forward arguments to formatPercent in NumberFormat::format() and remove percent check in Twig |number filter since it is redundant (NumberFormatter does the same thing).
diosmosis
added
not-in-changelog
added 2 commits
October 19, 2015 20:00
… not as many deprecated classes/methods are used, and add tests for NumberFormatter::format().
diosmosis
added a commit
that referenced
this pull request
Oct 20, 2015
Fixes #9049, in NumberFormatter::format() check for percent if value is a string only, since only strings will have a % (avoids floating point issues). Also includes some refactoring to NumberFormatter + its test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NumberFormatter::format() check for percent if value is a string only, since only strings will have a % (avoids floating point issues).
Also includes small refactor: forward arguments to formatPercent in NumberFormat::format() and remove percent check in Twig |number filter since it is redundant (NumberFormatter does the same thing).
Fixes #9049