Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only trigger piwikSwitchPage JS event when about to change piwik page. #9058

Merged
merged 1 commit into from Oct 20, 2015
Merged

Only trigger piwikSwitchPage JS event when about to change piwik page. #9058

merged 1 commit into from Oct 20, 2015

Conversation

diosmosis
Copy link
Member

Triggering when not changing the page causes Piwik to destroy graphs, w/o them ever being replaced.

Fixes #9018

Only trigger piwikSwitchPage JS event when about to change piwik page…
78cf4af 
…, instead of in admin menu & when just showing child elements of menu.
@diosmosis diosmosis added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels Oct 19, 2015
@diosmosis diosmosis added this to the 2.15.0 milestone Oct 19, 2015
mattab pushed a commit that referenced this pull request Oct 20, 2015
Merge pull request #9058 from piwik/9018_piwik_menu_switch
19cb7b9 
Only trigger piwikSwitchPage JS event when about to change piwik page.
@mattab mattab merged commit 19cb7b9 into master Oct 20, 2015
@mattab mattab deleted the 9018_piwik_menu_switch branch October 20, 2015 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @mattab