Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed PHP 5.3 support message to more generic "next major version" … #9047

Merged
merged 2 commits into from Nov 1, 2015
Merged

Changed PHP 5.3 support message to more generic "next major version" … #9047

merged 2 commits into from Nov 1, 2015

Conversation

sarelvdwalt
Copy link
Contributor

…according to issue #8847. This is only for english though, so we'll need translators for the 20 other languages that uses this. Once that is done we can remove the $dateDropSupport in \Piwik\Plugin\dateDropSupport:131. Fixes #8847

@sarelvdwalt
Changed PHP 5.3 support message to more generic "next major version" …
4691110 
…according to issue. This is only for english though, so we'll need translators for the 20 other languages that uses this. Once that is done we can remove the $dateDropSupport in \Piwik\Plugin\dateDropSupport:131. Fixes matomo-org#8847
@tsteur
Copy link
Member

tsteur commented Oct 26, 2015

Do you mind removing $dateDropSupport as you mentioned as well in https://github.com/piwik/piwik/blob/2.15.0/core/Plugin/ControllerAdmin.php#L132 ? otherwise there might be errors or so.

@tsteur
Copy link
Member

tsteur commented Oct 26, 2015

Thx for the PR btw :)

@sarelvdwalt
Copy link
Contributor Author

Hey there. I initially had it removed, but realised if I do that some of the other language files will then fail to parse properly. Example bg.json, line 370 still has the %s in there. I'd suggest leave it in there until all the language files have been updated ;)

@tsteur
Copy link
Member

tsteur commented Oct 29, 2015

@sgiehl I think once we update/change a translation I think all existing translation for other languages get cleared automatically right? In this case it would be fine.

@sarelvdwalt
Copy link
Contributor Author

I have removed the $dateDropSupport and amended the pull ;)

@sgiehl
Copy link
Member

sgiehl commented Oct 29, 2015

Correct. The translations will be cleared automatically with the next update.

tsteur added a commit that referenced this pull request Nov 1, 2015
@tsteur
Merge pull request #9047 from sarelvdwalt/master
da82737 
Changed PHP 5.3 support message to more generic "next major version" …
@tsteur tsteur merged commit da82737 into matomo-org:master Nov 1, 2015
@tsteur
Copy link
Member

tsteur commented Nov 1, 2015

Thx!

@mattab
Copy link
Member

mattab commented Nov 2, 2015

see follow up: when PHP is 5.4, display a warning message notifying users to upgrade to PHP 5.5 #9144

@mattab mattab added c: i18n For issues around internationalisation and localisation. and removed c: i18n For issues around internationalisation and localisation. labels Jan 29, 2016
@mattab mattab mentioned this pull request Oct 2, 2016
Merged
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it. c: i18n For issues around internationalisation and localisation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sarelvdwalt @tsteur @sgiehl @mattab